diff --git a/pointcloud_to_laserscan/launch/sample_node.launch b/pointcloud_to_laserscan/launch/sample_node.launch
index d5ca6c35..1d346365 100644
--- a/pointcloud_to_laserscan/launch/sample_node.launch
+++ b/pointcloud_to_laserscan/launch/sample_node.launch
@@ -16,7 +16,7 @@
#target_frame: # Leave disabled to output scan in pointcloud frame
- transform_tolerance: 0.0
+ transform_tolerance: 0.01
min_height: 0.0
max_height: 1.0
diff --git a/pointcloud_to_laserscan/launch/sample_nodelet.launch b/pointcloud_to_laserscan/launch/sample_nodelet.launch
index 79496023..ef784310 100644
--- a/pointcloud_to_laserscan/launch/sample_nodelet.launch
+++ b/pointcloud_to_laserscan/launch/sample_nodelet.launch
@@ -16,7 +16,7 @@
#target_frame: # Leave disabled to output scan in pointcloud frame
- transform_tolerance: 0.0
+ transform_tolerance: 0.01
min_height: 0.0
max_height: 1.0
diff --git a/pointcloud_to_laserscan/src/pointcloud_to_laserscan_nodelet.cpp b/pointcloud_to_laserscan/src/pointcloud_to_laserscan_nodelet.cpp
index 94d6616a..3321ef97 100644
--- a/pointcloud_to_laserscan/src/pointcloud_to_laserscan_nodelet.cpp
+++ b/pointcloud_to_laserscan/src/pointcloud_to_laserscan_nodelet.cpp
@@ -42,7 +42,7 @@
#include
#include
#include
-#include
+#include
namespace pointcloud_to_laserscan
{
@@ -58,7 +58,7 @@ namespace pointcloud_to_laserscan
private_nh_ = getMTPrivateNodeHandle();
private_nh_.param("target_frame", target_frame_, "");
- private_nh_.param("tolerance", tolerance_, 0.0);
+ private_nh_.param("tolerance", tolerance_, 0.01);
private_nh_.param("min_height", min_height_, 0.0);
private_nh_.param("max_height", max_height_, 1.0);
@@ -153,37 +153,61 @@ namespace pointcloud_to_laserscan
output.ranges.assign(ranges_size, output.range_max + 1.0);
}
- sensor_msgs::PointCloud2ConstIterator iter_x(*cloud_msg, "x");
- sensor_msgs::PointCloud2ConstIterator iter_y(*cloud_msg, "y");
- sensor_msgs::PointCloud2ConstIterator iter_z(*cloud_msg, "z");
+ // Pre-allocate for transformation
+ geometry_msgs::TransformStamped transform;
+ geometry_msgs::PointStamped in, out;
+ in.header = cloud_msg->header;
+
+ bool need_transform = !(output.header.frame_id == cloud_msg->header.frame_id);
+
+ // Fetch transform if necessary
+ if(need_transform)
+ {
+ try
+ {
+ transform = tf2_.lookupTransform(target_frame_, cloud_msg->header.frame_id, cloud_msg->header.stamp);
+ }
+ catch (tf2::TransformException ex)
+ {
+ NODELET_ERROR_STREAM("Transform failure: " << ex.what());
+ return;
+ }
+ }
+
+ // Iterate through pointcloud
+ sensor_msgs::PointCloud2ConstIterator iter_x(*cloud_msg, "x");
+ sensor_msgs::PointCloud2ConstIterator iter_y(*cloud_msg, "y");
+ sensor_msgs::PointCloud2ConstIterator iter_z(*cloud_msg, "z");
- geometry_msgs::Point32 point;
for(; iter_x != iter_x.end(); ++iter_x, ++iter_y, ++iter_z){
- point.x = *iter_x;
- point.y = *iter_y;
- point.z = *iter_z;
- if(!(output.header.frame_id == cloud_msg->header.frame_id)){
- point = tf2_.transform(point, output.header.frame_id, output.header.stamp, cloud_msg->header.frame_id);
+ const double *x = &(*iter_x), *y = &(*iter_y), *z = &(*iter_z);
+
+ // Do transform if necessary
+ if(need_transform){
+ in.point.x = *x; in.point.y = *y; in.point.z = *z;
+ tf2::doTransform(in, out, transform);
+ x = &out.point.x; y = &out.point.y; z = &out.point.z;
}
- if ( std::isnan(point.x) || std::isnan(point.y) || std::isnan(point.z) ){
- NODELET_DEBUG("rejected for nan in point(%f, %f, %f)\n", point.x, point.y, point.z);
+ if ( std::isnan(*x) || std::isnan(*y) || std::isnan(*z) ){
+ NODELET_DEBUG("rejected for nan in point(%f, %f, %f)\n", *x, *y, *z);
continue;
}
- if (point.z > max_height_ || point.z < min_height_){
- NODELET_DEBUG("rejected for height %f not in range (%f, %f)\n", point.z, min_height_, max_height_);
+ if (*z > max_height_ || *z < min_height_){
+ NODELET_DEBUG("rejected for height %f not in range (%f, %f)\n", *z, min_height_, max_height_);
continue;
}
- double range = hypot(point.x,point.y);
+ double range = hypot(*x,*y);
if (range < range_min_){
- NODELET_DEBUG("rejected for range %f below minimum value %f. Point: (%f, %f, %f)", range, range_min_, point.x, point.y, point.z);
+ NODELET_DEBUG("rejected for range %f below minimum value %f. Point: (%f, %f, %f)", range, range_min_, *x, *y,
+ *z);
continue;
}
- double angle = atan2(point.y, point.x);
+ double angle = atan2(*y, *x);
if (angle < output.angle_min || angle > output.angle_max){
NODELET_DEBUG("rejected for angle %f not in range (%f, %f)\n", angle, output.angle_min, output.angle_max);
continue;