From b4071f4aa65e9a32908b2dacbdc8e15362d1209b Mon Sep 17 00:00:00 2001 From: William Woodall Date: Sat, 13 Jul 2013 13:19:08 -0700 Subject: [PATCH] Fixup dependencies and CMakeLists.txt I added a versioned dependency on pcl, fixes #1, and I added a dependency on pcl_msgs, fixes #2, and I wrapped the test target in a CATKIN_ENABLE_TESTING check. --- CMakeLists.txt | 10 ++++++---- package.xml | 6 ++++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ee3b6e54..1da9af75 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,7 +1,7 @@ cmake_minimum_required(VERSION 2.8.3) project(pcl_conversions) -find_package(catkin REQUIRED COMPONENTS roscpp sensor_msgs std_msgs) +find_package(catkin REQUIRED COMPONENTS pcl_msgs roscpp sensor_msgs std_msgs) find_package(PCL REQUIRED QUIET COMPONENTS common) @@ -9,7 +9,7 @@ include_directories(include ${catkin_INCLUDE_DIRS} ${PCL_COMMON_INCLUDE_DIRS}) catkin_package( INCLUDE_DIRS include ${PCL_COMMON_INCLUDE_DIRS} - CATKIN_DEPENDS sensor_msgs std_msgs + CATKIN_DEPENDS pcl_msgs roscpp sensor_msgs std_msgs ) # Mark cpp header files for installation @@ -20,5 +20,7 @@ install(DIRECTORY include/${PROJECT_NAME}/ ) # Add gtest based cpp test target -catkin_add_gtest(${PROJECT_NAME}-test test/test_pcl_conversions.cpp) -target_link_libraries(${PROJECT_NAME}-test ${catkin_LIBRARIES}) +if(CATKIN_ENABLE_TESTING) + catkin_add_gtest(${PROJECT_NAME}-test test/test_pcl_conversions.cpp) + target_link_libraries(${PROJECT_NAME}-test ${catkin_LIBRARIES}) +endif() diff --git a/package.xml b/package.xml index aaebd1bc..fae4db33 100644 --- a/package.xml +++ b/package.xml @@ -14,12 +14,14 @@ catkin - pcl + pcl + pcl_msgs roscpp sensor_msgs std_msgs - pcl + pcl + pcl_msgs roscpp sensor_msgs std_msgs